Windows: Add hardening when renaming Phar during update#995
Draft
swissspidy wants to merge 1 commit intomainfrom
Draft
Windows: Add hardening when renaming Phar during update#995swissspidy wants to merge 1 commit intomainfrom
swissspidy wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the wp-cli/wp-cli dependency from dev-main to a specific feature branch (dev-fix/harden-update) aliased as version 2.13.0, with corresponding updates to the composer.lock file. Feedback was provided regarding the use of a feature branch as a dependency, noting that it should be reverted to a stable version or the main branch once the fix is merged to prevent potential build failures if the branch is deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test whether wp-cli/wp-cli#6297 fixes the following test failure here:
001 Scenario: Install WP-CLI nightly # features\cli.feature:119
When I run
{PHAR_PATH} cli update --nightly --yes# features\cli.feature:123$ php C:\Users\runneradmin\AppData\Local\Temp\wp-cli-test-run--69dea741de85d2.37607601\wp-cli-build-69dea741deb690.93926654.phar cli update --nightly --yes
Downloading from https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli-nightly.phar...
sha512 hash verified: 208bab2070a699bf87474ce711867fb2b6607f1ab27ab1efbe480b8815a1c2fadd1b7b50fe2aeced5038d46190196297c92c86cbc727df1dec7efa5f215dc25e
New version works. Proceeding to replace.