Fix DoKexDhReply() to reject the server's pub key if no PublicKeyCheck callback is registered#917
Merged
JacobBarthelmeh merged 3 commits intowolfSSL:masterfrom Apr 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the client-side KEXDH reply handling by changing DoKexDhReply() to reject a server host key when no PublicKeyCheck callback is registered, and adds a regression test to ensure this behavior is enforced.
Changes:
- Update
DoKexDhReply()to returnWS_PUBKEY_REJECTED_EwhenpublicKeyCheckCbisNULL. - Extend the KEXDH reply regression harness to optionally skip registering
PublicKeyCheck. - Add regression coverage asserting handshake failure when no
PublicKeyCheckcallback is configured.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/internal.c |
Changes default KEXDH reply behavior to reject server public keys when no verification callback is registered. |
tests/regress.c |
Adds a regression test and harness option to validate the new default rejection behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the default behavior of DoKexDhReplay() so that this rejects the pub key if no callback is registered.
Also, the new regression test case is added for that.