[INS-398] Added tests to ensure that custom endpoint configuration works in artifactory detectors#4832
Merged
MuneebUllahKhan222 merged 6 commits intotrufflesecurity:mainfrom Apr 14, 2026
Conversation
pkg/detectors/artifactoryreferencetoken/artifactoryreferencetoken_integration_test.go
Show resolved
Hide resolved
camgunz
approved these changes
Apr 10, 2026
Contributor
camgunz
left a comment
There was a problem hiding this comment.
There's something very "vanilla JS is all you need" about only using Go's builtin testing stuff, but we use testify all over the place and it simplifies things a lot, like you don't need things like:
got, err := s.FromData(ctx, true, data)
if err != nil {
t.Fatalf("unexpected error from FromData: %v", err)
}you can just do:
got, err := s.FromData(ctx, true, data)
// I usually leave the additional message off, but you do you
require.NoError(t, err, "unexpected error from FromData")
Contributor
|
Oh also I meant to say I love starting w/ tests here! 🏆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR adds test coverage for both Artifactory detectors by introducing:
for each detector.
The tests explicitly configure detector endpoints using
s.SetConfiguredEndpointsto ensure that:Purpose
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Low Risk
Low risk: changes are test-only and primarily add coverage around endpoint configuration and
RawV2construction for Artifactory detectors.Overview
Adds new unit and integration tests for the
artifactoryandartifactoryreferencetokendetectors to validate custom endpoint configuration viaSetConfiguredEndpoints.The new tests assert that configured endpoints are included in
Scanner.Endpoints()and that detection/verification buildsRawV2using the secret plus the configured endpoint (including URL trimming behavior for the reference-token detector).Reviewed by Cursor Bugbot for commit 46e57c3. Bugbot is set up for automated code reviews on this repo. Configure here.