Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Jennifer <5339211+jenpaff@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d90a3-46f3-75bc-baef-765e2f8b971f Co-authored-by: Amp <amp@ampcode.com>
jenpaff
force-pushed
the
docs/t3-upgrade-prep
branch
from
9e17b3f to
171d7d6
Compare
Co-authored-by: Jennifer <5339211+jenpaff@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d90a3-46f3-75bc-baef-765e2f8b971f Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Jennifer <5339211+jenpaff@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d91af-04a3-70ea-a3f9-19413f47dbc1 Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Jennifer <5339211+jenpaff@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d91af-04a3-70ea-a3f9-19413f47dbc1 Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Jennifer <5339211+jenpaff@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d91af-04a3-70ea-a3f9-19413f47dbc1 Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Jennifer <5339211+jenpaff@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d95b8-647a-77d9-9591-088166091a60 Co-authored-by: Amp <amp@ampcode.com>
legion2002
reviewed
Apr 16, 2026
Co-authored-by: Tanishk Goyal <goyaltanishk02@gmail.com>
0xrusowsky
approved these changes
Apr 16, 2026
Comment on lines
+21
to
+32
| <StaticMermaidDiagram chart={`flowchart LR | ||
| subgraph A[Without virtual addresses] | ||
| D1[Customer deposit address] --> B1[Separate onchain balance] | ||
| B1 --> S1[Sweep transaction] | ||
| S1 --> M1[Master wallet] | ||
| end | ||
|
|
||
| subgraph B[With virtual addresses] | ||
| D2[Customer virtual address] --> F2[TIP-20 forwarding] | ||
| F2 --> M2[Master wallet] | ||
| end | ||
| `} /> |
Contributor
There was a problem hiding this comment.
looks kinda ugly (really big and stacked, rather than parallel)
additionally would benefit from explaining the emitted events for full traceability
| - you keep one deposit address per customer | ||
| - the master wallet receives the balance directly | ||
| - no sweep transaction is needed | ||
| - no separate TIP-20 balance is created for each deposit address |
Contributor
There was a problem hiding this comment.
maybe worth pointing out that there is no double transfer, thus no perf/gas overhead (technically u pay 1 extra SLOAD)
Comment on lines
+75
to
+87
| <StaticMermaidDiagram chart={`sequenceDiagram | ||
| participant Sender | ||
| participant TIP20 as TIP-20 | ||
| participant Registry as Virtual registry | ||
| participant Master as Registered wallet | ||
|
|
||
| Sender->>TIP20: transfer(virtualAddress, amount) | ||
| TIP20->>Registry: resolve(masterId) | ||
| Registry-->>TIP20: master wallet | ||
| TIP20->>Master: credit balance | ||
| Note over TIP20: emits Transfer(sender → virtual, amount) | ||
| Note over TIP20: emits Transfer(virtual → master, amount) | ||
| `} /> |
Contributor
There was a problem hiding this comment.
nice, but would be really cool if we could have it as one of the animated diagrams like in mpp
|
|
||
| In practice: | ||
|
|
||
| - explorers and indexers should understand the two-hop `Transfer` pattern |
Contributor
There was a problem hiding this comment.
worth mentioning that no extra work is needed, as they are regular transfers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update protocol specs and docs based on t3 network upgrade