fix: restore ability to dump all configuration#2273
Open
jackhodgkiss wants to merge 2 commits intostackhpc/2025.1from
Open
fix: restore ability to dump all configuration#2273jackhodgkiss wants to merge 2 commits intostackhpc/2025.1from
jackhodgkiss wants to merge 2 commits intostackhpc/2025.1from
Conversation
When running `kayobe configuration dump` would fail with ``` ...FAILED! => \n msg: to_nice_yaml - 'hostvars'. 'hostvars' ``` This is due to the existence of variables that use `net_ip` filter. Therefore, this can be avoided by using `lookup` filter. Some of these changes are done within config and would be picked automatically. However some changes are done within the documentation and would require a user to update their configuration to benefit from the changes suggested. Note: This only works with you use `--limit` as the firewall configuration is within `all` group and gets evaluated by hosts that do not have network_interfaces such as switches. Due to the command producing a lot of output running the command without a `limit` it not advisable. Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the net_ip filter with a variable lookup for retrieving IP addresses across several configuration files, including OpenBao, Vault, and Wazuh-Agent. A correction is needed in the walled garden documentation where the NTP server configuration incorrectly includes a protocol and port intended for a proxy.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Member
|
Reno would be nice, otherwise looks good. |
jovial
approved these changes
Apr 16, 2026
dougszumski
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
kayobe configuration dumpwould fail withThis is due to the existence of variables that use
net_ipfilter. Therefore, this can be avoided by usinglookupfilter.Some of these changes are done within config and would be picked automatically. However some changes are done within the documentation and would require a user to update their configuration to benefit from the changes suggested.
Note: This only works with you use
--limitas the firewall configuration is withinallgroup and gets evaluated by hosts that do not have network_interfaces such as switches. Due to the command producing a lot of output running the command without alimitit not advisable.