fix(rbac): Restore listeners/finalizers update permission#384
Merged
NickLarsenNZ merged 2 commits intomainfrom Apr 16, 2026
Merged
fix(rbac): Restore listeners/finalizers update permission#384NickLarsenNZ merged 2 commits intomainfrom
NickLarsenNZ merged 2 commits intomainfrom
Conversation
Without the `listeners/finalizers` `update` rule, the listener operator is unable to set `metadata.ownerReferences[].blockOwnerDeletion` on the Service (or other) resource.
NickLarsenNZ
commented
Apr 16, 2026
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
sbernauer
approved these changes
Apr 16, 2026
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
I could imaging there are more OwnerReferencesPermissionEnforcement cases, but who knows
Member
Author
I went through the other's, but they didn't have finalizer permissions in the first place. |
18 tasks
sbernauer
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a rule accidentally removed in #380
Without the
listeners/finalizersupdaterule, the listener operator is unable to setmetadata.ownerReferences[].blockOwnerDeletionon the Service (or other) resource.This appears to have only affected OpenShift clusters in our testing because OpenShift enables the OwnerReferencesPermissionEnforcement admission plugin by default.