Skip to content

Devsvcs 4432/cron #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tarcisiozf wants to merge 3 commits into
base: main
Choose a base branch
from
+439 −133
Draft

Devsvcs 4432/cron #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42a9cbd
prompt to skip waiting
tarcisiozf Apr 14, 2026
878d27b
wip done signal
tarcisiozf Apr 14, 2026
4f5278b
done signal and prompt to skip wait
tarcisiozf Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/workflow/simulate/capabilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ func NewManualTriggerCapabilities(
limits *SimulationLimits,
) (*ManualTriggers, error) {
// Cron
manualCronTrigger := fakes.NewManualCronTriggerService(lggr)
manualCronTrigger, err := fakes.NewManualCronTriggerService(lggr)
if err != nil {
return nil, err
}
manualCronTriggerServer := crontrigger.NewCronServer(manualCronTrigger)
if err := registry.Add(ctx, manualCronTriggerServer); err != nil {
return nil, err
Expand Down
28 changes: 26 additions & 2 deletions cmd/workflow/simulate/simulate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,26 @@ func makeBeforeStartInteractive(holder *TriggerInfoAndBeforeStart, inputs Inputs
switch {
case trigger == "cron-trigger@1.0.0":
holder.TriggerFunc = func() error {
return triggerCaps.ManualCronTrigger.ManualTrigger(ctx, triggerRegistrationID, time.Now())
cronCtx, cancel := context.WithCancel(ctx)

go func() {
defer cancel()
ui.Line()
ui.WaitForEnter(cronCtx, "Cron scheduler started. Press Enter to skip waiting...")
}()

done, err := triggerCaps.ManualCronTrigger.ManualTrigger(cronCtx, triggerRegistrationID)
if err != nil {
cancel()
return err
}

go func() {
defer cancel()
<-done
}()

return nil
}
case trigger == "http-trigger@1.0.0-alpha":
payload, err := getHTTPTriggerPayload()
Expand Down Expand Up @@ -816,7 +835,12 @@ func makeBeforeStartNonInteractive(holder *TriggerInfoAndBeforeStart, inputs Inp
switch {
case trigger == "cron-trigger@1.0.0":
holder.TriggerFunc = func() error {
return triggerCaps.ManualCronTrigger.ManualTrigger(ctx, triggerRegistrationID, time.Now())
const nonInteractiveTimeout = 5 * time.Second
cronCtx, cancel := context.WithDeadline(ctx, time.Now().Add(nonInteractiveTimeout))
defer cancel()

_, err := triggerCaps.ManualCronTrigger.ManualTrigger(cronCtx, triggerRegistrationID)
return err
}
case trigger == "http-trigger@1.0.0-alpha":
if strings.TrimSpace(inputs.HTTPPayload) == "" {
Expand Down
Loading
Loading