Add finalized state check as optional interfaces to avoid breaking shared code#100
Draft
Krish-vemula wants to merge 3 commits intomainfrom
Draft
Add finalized state check as optional interfaces to avoid breaking shared code#100Krish-vemula wants to merge 3 commits intomainfrom
Krish-vemula wants to merge 3 commits intomainfrom
Conversation
|
Move this field out of the shared MultiNode struct to avoid imposing it on chains that don't use finalized state checking (e.g. Solana). The EVM side provides this value through its own NodePool config, and the framework's optional FinalizedStateCheckConfig interface handles the type assertion in node_lifecycle.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-introduces the finalized state availability check from PR #83, but decouples it from the shared NodeConfig and RPCClient interfaces by using optional interfaces (FinalizedStateCheckConfig, FinalizedStateChecker) with type assertions. This allows EVM to opt-in without forcing Solana to implement and audit no-op stubs.