fix(math): Remove a recursion in TeX-like accent logic causing an error#2305
Open
fix(math): Remove a recursion in TeX-like accent logic causing an error#2305
Conversation
Placing an accent (say `\bar`) over a single macro-defined command
(say a `\Phi`, or a `\mathbf{x}`) caused the engine to crash.
The accent logic was incorrectly re-compiling the already compiled
argument recursively. We were just lucky in other cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placing an accent (say
\bar) over a single macro-defined command (say a\Phi, or a\mathbf{x}) caused the engine to crash. The accent logic was incorrectly re-compiling the already compiled argument recursively. We were just lucky in other cases.Closes #2291
Checks
(All of these were previously crashing)
Details
We were re-compiling an already compiled tree.
Most of the time this would do nothing:
TL;DR. The key solution anyway is not to perform that useless re-compilation anyway.
Additionally, we were compiling accents from a constructed atom, but we actually know what we eventually want in MathML in that case, so it can be avoided (skipping another recursive evaluation).
My bad, when I implemented accents in Nov. 2024 🙄 (but I don't apologize, it was quite a struggle to get there).