test(cors): cover empty normalized bucket paths#129
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds focused unit coverage for the CORS bucket-path normalization fix introduced in the recent
corsparser update.The production code now rejects paths whose bucket segment becomes empty after trimming trailing slashes, but the existing regression test only covered the
local///case. That left the simplerlocal/andlocal//variants on the same code path untested.This PR adds assertions for those two inputs in the existing parser error test. The scope stays limited to the changed area and does not alter runtime behavior.
User impact
Users were already protected by the parser fix, but these two empty-bucket forms were not pinned by tests. Adding them reduces the chance of a future regression reintroducing acceptance of invalid CORS bucket paths.
Validation
cargo test test_parse_bucket_path_errorcargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceNote: the automation requested
make pre-commit, but this repository does not define that target. I ran the equivalent CI checks directly from.github/workflows/ci.ymlinstead.