Skip to content

fix(formatter): classify unsupported feature errors#123

Draft
overtrue wants to merge 1 commit intomainfrom
codex/formatter-inference-gap
Draft

fix(formatter): classify unsupported feature errors#123
overtrue wants to merge 1 commit intomainfrom
codex/formatter-inference-gap

Conversation

@overtrue
Copy link
Copy Markdown
Contributor

Summary

This change closes a formatter regression in the phase-3 structured error work. The formatter already inferred unsupported_feature for messages containing unsupported or does not support, but one of the new command error strings uses the phrase not yet supported instead. That path fell through to general_error, which meant JSON error output lost the expected error type and recovery hint.

The fix keeps scope narrow. It adds focused regression tests for the message-based conflict and unsupported_feature inference branches, then extends the unsupported-feature classifier to recognize not yet supported messages. The new unsupported test failed before this change and now passes with the classifier update.

Validation

I attempted to run make pre-commit, but this repository does not define that target or a Makefile/justfile. I ran the equivalent required checks from AGENTS.md instead:

  • cargo fmt --all --check
  • cargo clippy --workspace -- -D warnings
  • cargo test --workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant