Make OnDuplicate::Error the default for attributes#155308
Open
JonathanBrouwer wants to merge 2 commits intorust-lang:mainfrom
Open
Make OnDuplicate::Error the default for attributes#155308JonathanBrouwer wants to merge 2 commits intorust-lang:mainfrom
OnDuplicate::Error the default for attributes#155308JonathanBrouwer wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
| error: multiple `no_core` attributes | ||
| --> $DIR/malformed-no-std.rs:13:1 | ||
| | | ||
| LL | #![no_core("bar")] |
Contributor
There was a problem hiding this comment.
for valid input to no_core, so when there's not another error already, did multiple attributes give an error or did it pass silently. In which case: is this a breaking change?
Contributor
Author
There was a problem hiding this comment.
Yes this PR changes no_core from warn to err, but no_core is unstable so we can do this.
Note that the test has a feature gate.
Note that this PR changes this for all unstable attributes: 887a3f3
jdonszelmann
requested changes
Apr 15, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
duplicate_errs
branch
from
cbfae9a to
6e5e096
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
r=me after rebase |
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
duplicate_errs
branch
from
6e5e096 to
64a6dd8
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=jdonszelmann |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
…uwer Rollup of 5 pull requests Successful merges: - #154781 (Fix attribute order implementation) - #155242 (resolve: Introduce `(Local,Extern)Module` newtypes for local and external modules respectively) - #149614 (Use `MaybeDangling` in `std`) - #153178 (Add `TryFromIntError::kind` method and `IntErrorKind::NotAPowerOfTwo` variant) - #155049 (Documenting the case of `Weak::upgrade` returning `None` when the value behind the reference is missing) Failed merges: - #155308 (Make `OnDuplicate::Error` the default for attributes)
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
…uwer Rollup of 5 pull requests Successful merges: - #154781 (Fix attribute order implementation) - #155242 (resolve: Introduce `(Local,Extern)Module` newtypes for local and external modules respectively) - #149614 (Use `MaybeDangling` in `std`) - #153178 (Add `TryFromIntError::kind` method and `IntErrorKind::NotAPowerOfTwo` variant) - #155049 (Documenting the case of `Weak::upgrade` returning `None` when the value behind the reference is missing) Failed merges: - #155308 (Make `OnDuplicate::Error` the default for attributes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two changes, in separate commits for reviewability:
OnDuplicate::Warnto error.OnDuplicate::Errorthe default and removes the explicitON_DUPLICATEfor ones that currently already errorr? @jdonszelmann