Modify Version#payload to include alias to number called version to match Rubygem attributes#5776
Open
zenspider wants to merge 2 commits intorubygems:masterfrom
Open
Modify Version#payload to include alias to number called version to match Rubygem attributes#5776zenspider wants to merge 2 commits intorubygems:masterfrom
zenspider wants to merge 2 commits intorubygems:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5776 +/- ##
==========================================
- Coverage 97.15% 94.40% -2.75%
==========================================
Files 460 460
Lines 9559 9618 +59
==========================================
- Hits 9287 9080 -207
- Misses 272 538 +266 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9626777 to
00a90ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found it incredibly awkward that
https://rubygems.org/api/v1/gems/rubygems-update.json
returns an attribute called version, but
https://rubygems.org/api/v1/versions/rubygems-update.json
does not. This fixes that w/o breaking backwards compatibility.
I am pushing this PR to get the tests to run. They won't run on my branch on my fork. Please disregard until green.