Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mypy/fastparse.py
Original file line number Diff line number Diff line change
Expand Up @@ -1958,7 +1958,10 @@ def visit_Call(self, e: Call) -> Type:
if not isinstance(self.parent(), ast3.List):
note = None
if constructor:
note = "Suggestion: use {0}[...] instead of {0}(...)".format(constructor)
if e.keywords:
note = "Cannot use a function call in a type annotation"
else:
note = "Suggestion: use {0}[...] instead of {0}(...)".format(constructor)
return self.invalid_type(e, note=note)
if not constructor:
self.fail(message_registry.ARG_CONSTRUCTOR_NAME_EXPECTED, e.lineno, e.col_offset)
Expand Down
11 changes: 11 additions & 0 deletions test-data/unit/check-fastparse.test
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,17 @@ def f(a: Foo(int)) -> int:
main:7: error: Invalid type comment or annotation
main:7: note: Suggestion: use Foo[...] instead of Foo(...)

[case testFasterParseCallWithKeywordArgs_no_native_parse]

def Foo(sort: bool) -> type:
return int

def f(a: Foo(sort=True)) -> int:
pass
[out]
main:5: error: Invalid type comment or annotation
main:5: note: Cannot use a function call in a type annotation

[case testFastParseMatMul]

from typing import Any
Expand Down
Loading