Do not exclude misc/sync-typeshed.py from from tox self-check#19926

Open

wyattscarpenter wants to merge 7 commits intopython:masterfrom

wyattscarpenter:mi

Contributor

wyattscarpenter commented Sep 25, 2025 •

edited

Loading

It's fine; we can just typecheck it.

This also requires installing types-requests, so I change the test requirements file to list this.


          do not exclude misc/sync-typeshed.pyfrom from tox self-check

b656a93

it's fine; we can just typecheck it

wyattscarpenter changed the title ~~do not exclude misc/sync-typeshed.pyfrom from tox self-check~~ do not exclude misc/sync-typeshed.py from from tox self-check

wyattscarpenter marked this pull request as draft

September 25, 2025 17:58

This comment has been minimized.

Sign in to view

wyattscarpenter and others added 2 commits

September 26, 2025 16:31


          Install types-request, as required by the newly-checked code.

bdaf9d4


          [pre-commit.ci] auto fixes from pre-commit.com hooks

f69999b

for more information, see https://pre-commit.ci

This comment has been minimized.

Sign in to view

Contributor Author

wyattscarpenter commented Sep 27, 2025

Diff from mypy_primer, showing the effect of this PR on open source code:

graphql-core (https://github.com/graphql-python/graphql-core)
- version: 1.19.0+dev.19697af9051707b4db55bc2d5301436d872f452c
+ version: 1.19.0+dev.a3043d1fa245791ea4849437963d417fba25f21d

Real.

wyattscarpenter changed the title ~~do not exclude misc/sync-typeshed.py from from tox self-check~~ Do not exclude misc/sync-typeshed.py from from tox self-check

wyattscarpenter mentioned this pull request

Mysterious diff in primer output that solely shows that the version of mypy changed, and only for graphql-core hauntsaninja/mypy_primer#215

Closed

wyattscarpenter marked this pull request as ready for review

September 27, 2025 00:17


          Merge branch 'master' into mi

f767655

This comment has been minimized.

Sign in to view


          Merge branch 'master' into mi

7dcfbe4

This comment has been minimized.

Sign in to view


          Merge branch 'master' into mi

8fbd217

This comment has been minimized.

Sign in to view


          Merge branch 'master' into mi

1cdd5f3

Contributor

github-actions bot commented Apr 16, 2026

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet