ext/session: fix missing zval_ptr_dtor for retval in PS_GC_FUNC(user)#21747
Open
jorgsowa wants to merge 1 commit intophp:PHP-8.4from
Open
ext/session: fix missing zval_ptr_dtor for retval in PS_GC_FUNC(user)#21747jorgsowa wants to merge 1 commit intophp:PHP-8.4from
jorgsowa wants to merge 1 commit intophp:PHP-8.4from
Conversation
Girgias
approved these changes
Apr 14, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Needs to be backported to 8.4.
PS_GC_FUNC(user) did not call zval_ptr_dtor() on the return value of the user GC callback, leaking memory when the callback returned a reference-counted value. All other user handlers (write, destroy, validate_sid, update_timestamp) already free retval correctly.
jorgsowa
force-pushed
the
fix/session-gc-retval-leak
branch
from
1c709a2 to
2330863
Compare
Girgias
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS_GC_FUNC(user) did not call zval_ptr_dtor() on the return value of the user GC callback, leaking memory when the callback returned a reference-counted value. All other user handlers (write, destroy, validate_sid, update_timestamp) already free retval correctly.