fix(switch): add static accessible label#3094
Merged
bennypowers merged 5 commits intomainfrom Apr 15, 2026
Merged
Conversation
Rename `label` property to `accessibleLabel` (attribute: `accessible-label`) for consistency. Wire it to set `ariaLabel` on element internals for a proper static accessible name. Closes #2754 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9251fb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(switch): add static accessible label"
} |
Contributor
Contributor
zeroedin
reviewed
Apr 15, 2026
Keep the existing `label` property as deprecated and fall back to it when `accessible-label` is not set. JSDoc advises updating the accessible label based on checked state. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
This comment has been minimized.
This comment has been minimized.
zeroedin
approved these changes
Apr 15, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
labelproperty toaccessibleLabel(accessible-labelattribute)ariaLabelon ElementInternals for a proper static accessible nameaccessible-labelCloses #2754
Test plan
accessible-labelis setnpx wtr elements/pf-switch/test/pf-switch.spec.ts