-
Notifications
You must be signed in to change notification settings - Fork 8
chore: disable adaptive thinking via env var #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| { | ||
| "env": { | ||
| "CLAUDE_CODE_DISABLE_ADAPTIVE_THINKING": "1" | ||
| }, | ||
| "hooks": { | ||
| "PreToolUse": [ | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLAUDE.md mandates "One PR = one concern." This PR's title describes only the
CLAUDE_CODE_DISABLE_ADAPTIVE_THINKINGsettings change, but it contains five additional unrelated commits: new/titan-grindskill, updated/titan-run//titan-close//titan-resetpipeline skills, an enhanced/architectskill with dual-lens scoring, new documentation reports, and deletion of the old architecture audit.Each of those should be its own PR so history stays navigable and reviewers can evaluate each change in isolation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — the unrelated commits (titan-grind, titan-run, architect, docs reports) were from an earlier branch that got merged into main via separate PRs. After merging main into this branch, the diff now contains only the settings.json env var change and the .gitignore addition. The PR is now single-concern as intended.