Skip to content

fix(devtools): add undeclared unstorage dependency#986

Open
danielroe wants to merge 1 commit intomainfrom
fix/unstorage
Open

fix(devtools): add undeclared unstorage dependency#986
danielroe wants to merge 1 commit intomainfrom
fix/unstorage

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

#940

📚 Description

a few users have reported this - devtools currently relies on an implicit unstorage dependency, which will not always work

so I thought we could fix in current major of devtools rather than waiting for #940

@danielroe danielroe requested a review from antfu April 15, 2026 13:33
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying nuxt-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: bb5788e
Status: ✅  Deploy successful!
Preview URL: https://39edd841.nuxt-devtools.pages.dev
Branch Preview URL: https://fix-unstorage.nuxt-devtools.pages.dev

View logs

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d6ee6730-cfbe-48f0-9ca8-f5be8ba442db

📥 Commits

Reviewing files that changed from the base of the PR and between 7bf7b36 and bb5788e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • packages/devtools/package.json
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

Two files were modified to add the unstorage package as a dependency. The pnpm-workspace.yaml file was updated to define unstorage: ^1.17.5 in the catalogs.prod section, establishing a version specification for the workspace. The packages/devtools/package.json file was then updated to add unstorage as a dependency, referencing the catalog entry rather than pinning to a specific version directly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: adding an undeclared unstorage dependency to devtools.
Description check ✅ Passed The description is directly related to the changeset, explaining the issue (implicit dependency that fails) and the solution (explicitly adding the dependency).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/unstorage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant