feat(core): Scale expression isolate pool to 0 after inactivity#28472
Open
feat(core): Scale expression isolate pool to 0 after inactivity#28472
Conversation
Bundle ReportChanges will increase total bundle size by 42 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: editor-ui-esmAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
No issues found across 9 files
Architecture diagram
sequenceDiagram
participant CLI as CLI / BaseCommand
participant Pool as IsolatePool
participant Bridge as RuntimeBridge (V8 Isolate)
participant Obs as Observability / Metrics
Note over CLI,Obs: Engine Initialization
CLI->>Pool: initialize()
Pool->>Bridge: NEW: createBridge() x N
Pool->>Obs: reportPoolSize(N)
Pool->>Pool: NEW: startIdleTimer(idleTimeoutMs)
Note over CLI,Obs: Normal Request Flow (Activity)
CLI->>Pool: acquire()
Pool->>Pool: CHANGED: startIdleTimer() (Reset)
Pool-->>CLI: return bridge
Pool->>Bridge: execute expression
CLI->>Pool: release(bridge)
Pool->>Bridge: dispose()
Pool->>Bridge: replenish()
Note over CLI,Obs: NEW: Scale-to-Zero Flow (Inactivity)
Pool->>Pool: idleTimer expires
Pool->>Pool: scaleToZero()
Pool->>Pool: waitForReplenishment() (Safety check)
alt isIdle is still true
Pool->>Bridge: dispose() all warm bridges
Pool->>Obs: NEW: counter("scaled_to_zero")
Pool->>Obs: gauge("pool.size", 0)
end
Note over CLI,Obs: NEW: Wake-up Flow (Recovery)
CLI->>Pool: acquire()
alt wasIdle
Pool->>Pool: isIdle = false
Pool->>Obs: NEW: counter("scaled_up")
Pool->>Pool: startIdleTimer()
Pool->>Pool: replenish() (Scale back to N)
end
Pool-->>CLI: throw PoolExhaustedError (While warming)
loop replenishment
Pool->>Bridge: createBridge()
Bridge-->>Pool: ready
Pool->>Obs: gauge("pool.size", count++)
end
Merging this PR will degrade performance by 33.02%
Performance Changes
Comparing Footnotes
|
Contributor
Performance ComparisonComparing current → latest master → 14-day baseline Memory consumption baseline with starter plan resources
docker-stats
Idle baseline with Instance AI module loaded
How to read this table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/CAT-2781/