Skip to content

🐛 ♻️ optimize un-needed buffer management in image crop extraction #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastianMindee merged 2 commits into from
Apr 10, 2026
+14 −16
Merged

🐛 ♻️ optimize un-needed buffer management in image crop extraction #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
100d064
:bug: :recycle: optimize un-needed buffer management in image crop ex…
sebastianMindee Apr 10, 2026
87ce681
fix syntax
sebastianMindee Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions lib/mindee/image/image_extractor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,35 +37,33 @@ def self.extract_multiple_images_from_source(input_source, page_id, polygons)
new_stream = load_input_source_pdf_page_as_stringio(input_source, page_id)
new_stream.seek(0)

extract_images_from_polygons(input_source, new_stream, page_id, polygons)
extract_images_from_polygons(input_source, page_id, polygons)
end

# Extracts images from their positions on a file (as polygons).
#
# @param [Input::Source::LocalInputSource] input_source Local input source.
# @param [StringIO] pdf_stream Buffer of the PDF.
# @param [Integer] page_id Page ID.
# @param [Array<Geometry::Point, Geometry::Polygon, Geometry::Quadrilateral>] polygons
# @return [Array<Image::ExtractedImage>] Extracted Images.
def self.extract_images_from_polygons(input_source, pdf_stream, page_id, polygons)
def self.extract_images_from_polygons(input_source, page_id, polygons)
extracted_elements = [] # @type var extracted_elements: Array[Image::ExtractedImage]

input_source.io_stream.rewind
pdf_stream = StringIO.new(input_source.io_stream.read.to_s)
input_source.io_stream.rewind
polygons.each_with_index do |polygon, element_id|
polygon = ImageUtils.normalize_polygon(polygon)
page_content = ImageUtils.read_page_content(pdf_stream)
points = [
polygon.top_left,
polygon.bottom_right,
polygon.top_right,
polygon.bottom_left,
]

min_max_x = Geometry.get_min_max_x([
polygon.top_left,
polygon.bottom_right,
polygon.top_right,
polygon.bottom_left,
])
min_max_y = Geometry.get_min_max_y([
polygon.top_left,
polygon.bottom_right,
polygon.top_right,
polygon.bottom_left,
])
min_max_x = Geometry.get_min_max_x(points)
min_max_y = Geometry.get_min_max_y(points)
file_extension = ImageUtils.determine_file_extension(input_source)
cropped_image = ImageUtils.crop_image(page_content, min_max_x, min_max_y)
if file_extension == 'pdf'
Expand Down
2 changes: 1 addition & 1 deletion sig/mindee/image/image_extractor.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module Mindee
def self.attach_image_as_new_file: (StringIO | File, ?format: String) -> Origami::PDF
def self.to_blob: () -> String
def self.extract_multiple_images_from_source: (Input::Source::LocalInputSource, Integer, Array[Array[Geometry::Point] |Geometry::Polygon | Geometry::Quadrilateral]) -> Array[ExtractedImage]
def self.extract_images_from_polygons: (Input::Source::LocalInputSource, StringIO | File, Integer, Array[Array[Geometry::Point] | Geometry::Polygon | Geometry::Quadrilateral]) -> Array[ExtractedImage]
def self.extract_images_from_polygons: (Input::Source::LocalInputSource, Integer, Array[Array[Geometry::Point] | Geometry::Polygon | Geometry::Quadrilateral]) -> Array[ExtractedImage]
def self.create_extracted_image: (StringIO | File, String, Integer, Integer) -> ExtractedImage
def self.load_input_source_pdf_page_as_stringio: (Input::Source::LocalInputSource, Integer) -> (StringIO | File)
end
Expand Down
Loading