FIX: GUI target config shows wrong model name due to env var override

[romanlutz]

Problem

Users reported that the GUI's target configuration view showed incorrect model names. When creating a target with a specific model name (e.g., claude-sonnet-4-6), the target table would display gpt-4o instead — pulled from the OPENAI_CHAT_UNDERLYING_MODEL environment variable.

This affected:

• GUI-created targets: Any model name entered in the Create Target dialog was overridden
• Initializer-registered targets: Targets like DeepSeek, Mistral, Gemini, Llama, and GPT-4.1 all incorrectly showed gpt-4o

Root Cause

OpenAITarget.__init__ read underlying_model from a class-level env var (e.g., OPENAI_CHAT_UNDERLYING_MODEL) and used it to override model_name in the identifier. Since all OpenAIChatTarget instances shared the same env var, unrelated targets got the wrong model name.

Fix

Simplify underlying_model — remove class-level env var logic

Env var reading for underlying_model is now the initializer's responsibility, not the target class's. The .env file and TargetConfig registry stay exactly as-is.

What changed:

• OpenAITarget: Removed underlying_model_environment_variable attribute and env var reading in __init__. Just passes underlying_model through directly.
• 7 subclasses: Removed self.underlying_model_environment_variable = "..." from each _set_openai_env_configuration_vars()
• PromptTarget: Stores underlying_model directly (removed underlying_model_env_var and model_name_was_explicit params)
• default_values.py: Removed resolve_underlying_model()

What stayed the same:

• .env files: All underlying model env vars stay
• TargetConfig in the initializer: Still reads env vars via os.getenv(config.underlying_model_var) and passes as explicit underlying_model= kwargs

Consistent naming

Aligned naming across the entire stack:

• model_name = what the user enters (deployment name used in API calls)
• underlying_model_name = the actual model behind it, if different (e.g., Azure deployment my-deploy → underlying gpt-4o)

Identifier changes

_create_identifier() now stores both model_name (user's input) and underlying_model_name (if set) as separate params. The backend mapper surfaces both to the frontend.

Frontend

• CreateTargetDialog: Added toggle for specifying a different underlying model (hidden by default), with explanation about Azure deployment names.
• TargetTable: Flat table with type filter dropdown, active target indicator above table, model tooltip when underlying model differs, line-wrapped parameters, wider endpoint column.
• ChatWindow: Shows model_name in the target badge.

Tests

Backend

• test_create_target_model_name_not_overridden_by_env_var — env var no longer overrides explicit model_name
• test_create_target_with_different_underlying_model — explicit underlying_model preserved separately
• test_get_identifier_ignores_underlying_model_env_var_* — chat target, response target
• test_underlying_model_param_takes_precedence_over_env_var — explicit param wins
• Updated existing identifier tests for renamed fields

Frontend

• 15 TargetTable tests: flat table, filter, active indicator, tooltip, params
• 2 CreateTargetDialog tests: toggle on/off for underlying model
• All 503 frontend tests pass, all 1118+ backend tests pass

[Copilot]

Pull request overview

Fixes incorrect model name display in the GUI when an OpenAI underlying-model environment variable was unintentionally overriding explicitly provided model/deployment names. This aligns target identifiers and API responses with what users actually configured, while still preserving the underlying model when it’s intentionally provided.

Changes:

• Update OpenAI target initialization to only use the underlying-model env var when the deployment/model name is also coming from env vars.
• Add deployment_name to target identifiers and surface it through backend DTOs/API and frontend types/UI.
• Redesign the TargetTable UI (grouped/collapsible sections, expand/collapse controls, tooltip when underlying model differs) and adjust related tests/e2e.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/unit/target/test_openai_response_target.py	Adds unit test coverage for env var override behavior (response target).
tests/unit/target/test_openai_chat_target.py	Refines env var override tests; asserts deployment_name preservation.
tests/unit/backend/test_target_service.py	Adds service-layer test ensuring GUI create path preserves explicit model/deployment name.
pyrit/prompt_target/openai/openai_target.py	Adjusts underlying-model env var fallback logic to avoid overriding explicit model_name.
pyrit/prompt_target/common/prompt_target.py	Adds deployment_name into target identifiers alongside model_name.
pyrit/backend/models/targets.py	Extends TargetInstance DTO with deployment_name and clarifies model_name semantics.
pyrit/backend/mappers/target_mappers.py	Maps deployment_name from identifier params into TargetInstance responses.
frontend/src/types/index.ts	Adds deployment_name to the frontend TargetInstance type.
frontend/src/components/Config/TargetTable.tsx	Implements grouped/collapsible TargetTable UI and tooltip behavior.
frontend/src/components/Config/TargetTable.test.tsx	Updates/adds tests for new TargetTable grouping and expand/collapse behaviors.
frontend/src/components/Config/TargetTable.styles.ts	Adds styling to support multi-line parameter display.
frontend/src/components/Config/CreateTargetDialog.tsx	Adds optional “underlying model differs” toggle and field; sends underlying_model when set.
frontend/src/components/Config/CreateTargetDialog.test.tsx	Updates placeholder text in tests to match dialog copy change.
frontend/src/components/Chat/ChatWindow.tsx	Displays deployment_name in the active target badge when available.
frontend/e2e/config.spec.ts	Updates placeholder text used by e2e test to match dialog copy change.