Skip to content

fix(ingester): infer gvk from crd#911

Open
aritra0227 wants to merge 1 commit intomainfrom
ghosharitra/unblock-sandbox-via-ingester-fix
Open

fix(ingester): infer gvk from crd#911
aritra0227 wants to merge 1 commit intomainfrom
ghosharitra/unblock-sandbox-via-ingester-fix

Conversation

@aritra0227
Copy link
Copy Markdown
Contributor

@aritra0227 aritra0227 commented Mar 19, 2026

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

What changed?
The registration for each ingester controller requires the GVK from each CRD and then a controller named ingester_<GVK> is registered. However, the GVK is not set by default and hence obj.GetObjectKind().GroupVersionKind() returns empty hence an ingester-controller with the name ingester_ is attempted to be registered. Therefore we encounter the following error in the second ingester-controller registration:

controller with name ingester_ already exists. Controller names must be unique to avoid multiple controllers reporting to the same metric

How did you test it?
Ran sandbox against changes. All ingester controllers were registered:
Screenshot 2026-03-18 at 5 32 58 PM

@github-actions
Copy link
Copy Markdown

🔍 Go Lint & TODO Tracking Results

⚠️ golangci-lint: Issues detected

level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`."
level=warning msg="[config_reader] The configuration option `output.format` is deprecated, please use `output.formats`"
Error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.3)
Failed executing command with error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.3)

✅ TODO Tracking: All TODOs properly linked to issues

@github-actions
Copy link
Copy Markdown

Go Coverage Report (Bazel)

Total Coverage: 62.7%

Coverage Policy:

  • Baseline (existing code): ≥60% (current coverage)
  • New/changed code: ≥90% ✅ STRICTLY ENFORCED
  • Long-term goal: Improve baseline to 90%

View detailed HTML report in artifacts

@github-actions
Copy link
Copy Markdown

📊 Combined Coverage Report

Component Coverage Baseline New Code Status
🐍 Python 82.62% ≥70% ≥90% ✅
🐹 Go 62.7% ≥60% ≥90% ✅
📜 JavaScript N/A% (no coverage data) ≥78.74% ≥90% ✅ ⏭️

Coverage Policy

Baseline (Existing Code):

  • Python: ≥70% (current coverage)
  • Go: ≥60% (current coverage)
  • JavaScript: ≥78.74% (current coverage)

New/Changed Code: ≥90% STRICTLY ENFORCED

Long-term Goal: Maintain and improve coverage baselines


📝 Coverage Guidelines
  • All new code must include tests
  • Coverage should not decrease from the base branch
  • Use # pragma: no cover sparingly for truly untestable code
  • Aim for meaningful tests, not just coverage numbers
🔗 Quick Links

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants