Skip to content

fix: change rate-limit log level from info to debug#7117

Draft
iegl3 wants to merge 2 commits intolouislam:masterfrom
iegl3:fix/rate-limit-debug-log
Draft

fix: change rate-limit log level from info to debug#7117
iegl3 wants to merge 2 commits intolouislam:masterfrom
iegl3:fix/rate-limit-debug-log

Conversation

@iegl3
Copy link
Copy Markdown

@iegl3 iegl3 commented Mar 8, 2026

Summary

In this pull request, the following changes are made:

  • Changed log.info() to log.debug() for the rate-limit "remaining requests" message in server/rate-limiter.js. This message logs on every single request, which floods the log output unnecessarily. Debug level keeps it available when needed but hidden by default.
Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Screenshots for Visual Changes

  • UI Modifications: Highlight any changes made to the user interface.
  • Before & After: Include screenshots or comparisons (if applicable).
Event Before After
UP Before After
DOWN Before After
Certificate-expiry Before After
Testing Before After

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 8, 2026

Hello and thanks for lending a paw to Uptime Kuma! 🐻👋
As this is your first contribution, please be sure to check out our Pull Request guidelines.
In particular: - Mark your PR as Draft while you’re still making changes - Mark it as Ready for review once it’s fully ready
If you have any design or process questions, feel free to ask them right here in this pull request - unclear documentation is a bug too.

@iegl3 iegl3 changed the title change rate-limit log level from info to debug fix: change rate-limit log level from info to debug Mar 8, 2026
Copy link
Copy Markdown
Owner

@louislam louislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the same pr 2 years ago, see the review here.

#5402 (comment)

async pass(callback, num = 1) {
const remainingRequests = await this.removeTokens(num);
log.info("rate-limit", "remaining requests: " + remainingRequests);
log.debug("rate-limit", "remaining requests: " + remainingRequests);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this might be annoying to you, please fix this properly.

If very few requests are remaining, this is a warning, else debug.

@CommanderStorm CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label Mar 8, 2026
@CommanderStorm CommanderStorm marked this pull request as draft March 8, 2026 06:06
@iegl3 iegl3 marked this pull request as ready for review March 8, 2026 06:49
@CommanderStorm CommanderStorm marked this pull request as draft March 8, 2026 07:01
@CommanderStorm CommanderStorm added pr:please address review comments this PR needs a bit more work to be mergable and removed pr:needs review this PR needs a review by maintainers or other community members labels Mar 8, 2026
mahdirajaee

This comment was marked as spam.

@CommanderStorm
Copy link
Copy Markdown
Collaborator

@mahdirajaee feel free to contribute the proper fix for this if this is annoying you. This PR seems a bit stuck.
I won't make it debug without the change that louis asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please address review comments this PR needs a bit more work to be mergable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RATE-LIMIT log message every 10 seconds, even with all monitors paused.

4 participants