credentials: auto-enable VPC endpoint when running in VPC network#1653
Open
huww98 wants to merge 1 commit intokubernetes-sigs:masterfrom
Open
credentials: auto-enable VPC endpoint when running in VPC network#1653huww98 wants to merge 1 commit intokubernetes-sigs:masterfrom
huww98 wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
3a6149d to
fd471d7
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fd471d7 to
2669950
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
When the CSI driver is running in a VPC network, the Alibaba Cloud credentials SDK supports using VPC endpoints for authentication (controlled by the
ALIBABA_CLOUD_VPC_ENDPOINT_ENABLEDenvironment variable). Previously, users had to manually set this environment variable to enable VPC endpoint usage.This PR automatically sets
ALIBABA_CLOUD_VPC_ENDPOINT_ENABLED=truewhen:vpc(viautils.GetNetworkType())This improves out-of-the-box behavior for VPC deployments without breaking existing configurations where the variable is explicitly set.
Which issue(s) this PR fixes:
No linked issues
Special notes for your reviewer:
The check uses
os.LookupEnvto preserve any existing user-set value (includingfalse) and only auto-sets when the variable is absent.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: