test: Implement tests for Navigation history dialog#4811
test: Implement tests for Navigation history dialog#4811harshsomankar123-tech wants to merge 3 commits intokiwix:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4811 +/- ##
============================================
+ Coverage 60.62% 60.67% +0.05%
- Complexity 1667 1675 +8
============================================
Files 333 333
Lines 16037 16037
Branches 2224 2224
============================================
+ Hits 9722 9731 +9
+ Misses 4843 4830 -13
- Partials 1472 1476 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@MohitMaliFtechiz Please Take A look |
| * click interactions, app bar integration, and action menu state. | ||
| */ | ||
| @RunWith(AndroidJUnit4::class) | ||
| class NavigationHistoryDialogScreenTest { |
There was a problem hiding this comment.
@harshsomankar123-tech The testing setup is good. But I have a question. Why are we not writing these test cases with Robolectric as we did for ReaderScreenComposableTest? These tests will run on an emulator, which takes more time. Is there any reason behind it?
There are detekt issue please fix that.
There was a problem hiding this comment.
Hi @MohitMaliFtechiz, thank you for the review!
You're absolutely right. Since these are pure Compose UI tests (rendering, clicks, callbacks) and don't require any device-specific features, there's no reason to run them as instrumentation tests on an emulator.
I will make changes with Robolectric Test PTAL
Thanks for catching this!
dd2f343 to
1fbf95e
Compare
FIX #4809