change copy prompt button hover to underline#330
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR only modifies UI styling for a copy prompt button hover effect, not kernel API endpoints or Temporal workflows. To monitor this PR anyway, reply with |
| cursor: 'pointer', | ||
| transition: 'background-color 0.15s ease, border-color 0.15s ease', | ||
| textDecoration: 'none', | ||
| transition: 'text-decoration 0.15s ease', |
There was a problem hiding this comment.
Transition on non-animatable text-decoration-line is ineffective
Low Severity
The transition: 'text-decoration 0.15s ease' declaration is dead code. CSS cannot transition text-decoration-line (which is what changes between none and underline). Only text-decoration-color and text-decoration-thickness are animatable sub-properties. The underline will still appear and disappear on hover, but it snaps instantly with no smooth transition, making this line misleading.
Reviewed by Cursor Bugbot for commit f5e30a8. Configure here.
… loading pop-in" This reverts commit 6e3f46a.
Risk assessment update after new commits: Low risk (increased from previous Very Low), so I’m dismissing the earlier approval.
What changed in the latest diff:
snippets/copy-prompt-button.jsx: addsuseLayoutEffectand direct DOM manipulation to hide a placeholder element after hydration, plus hover style behavior updates.index.mdx: adds a static placeholder button-like element in page markup.style.css: adds new global placeholder styling.
Why risk increased:
- The change is no longer only a narrowly scoped hover-style tweak; it now introduces runtime behavior tied to hydration timing and direct DOM querying.
- It remains limited to docs UI and does not touch backend, auth, infra, or shared service logic, so overall risk is still Low, not medium/high.
Decision:
- Approval dismissed due to increased risk after synchronize.
- Current classification: Low risk.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6e3f46a. Configure here.
| cursor: pointer; | ||
| font-family: inherit; | ||
| box-sizing: border-box; | ||
| } |
There was a problem hiding this comment.
Placeholder width doesn't match button's actual rendered width
Medium Severity
The new .copy-prompt-placeholder has max-width: 352px, but the actual <button> rendered by CopyPromptButton has its max-width overridden to 100% by the existing .tinker-box-content button { max-width: 100% !important; } rule. On any screen where the content area is wider than 352px, the placeholder renders at 352px while the hydrated button stretches to fill the container — causing a visible layout shift, which is exactly what the placeholder was designed to prevent.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 6e3f46a. Configure here.
There was a problem hiding this comment.
Risk assessment: Very Low.
I reviewed the actual diff for this update. The PR changes a single UI snippet (snippets/copy-prompt-button.jsx) and only adjusts hover styling behavior for the copy button (switching from background/border hover styling to underline text decoration). There are no logic-flow changes, no data/auth/permission impact, no infrastructure changes, and no shared backend surface affected.
Given the small, isolated frontend presentation-only scope and low blast radius, this is safe to approve.
Sent by Cursor Automation: Assign PR reviewers




replaces the background/border color hover effect on the copy prompt button with a simple text underline on hover, matching the standard link hover pattern on the site.
only the copy prompt button on the home page had this — no other interactive elements in the docs use a non-standard hover pattern.
Note
Low Risk
Low risk UI-only change limited to hover styling on the copy prompt button; no behavior, state, or data handling is modified.
Overview
Updates
CopyPromptButtonhover styling to match a standard link pattern by replacing the background/border color hover effect with an underline (textDecoration) and adjusting the CSS transition accordingly.Reviewed by Cursor Bugbot for commit 41d71e8. Bugbot is set up for automated code reviews on this repo. Configure here.