Skip to content

change copy prompt button hover to underline#330

Merged
masnwilliams merged 3 commits intomainfrom
hypeship/underline-hover-button
Apr 15, 2026
Merged

change copy prompt button hover to underline#330
masnwilliams merged 3 commits intomainfrom
hypeship/underline-hover-button

Conversation

@masnwilliams
Copy link
Copy Markdown
Contributor

@masnwilliams masnwilliams commented Apr 15, 2026

replaces the background/border color hover effect on the copy prompt button with a simple text underline on hover, matching the standard link hover pattern on the site.

only the copy prompt button on the home page had this — no other interactive elements in the docs use a non-standard hover pattern.


Note

Low Risk
Low risk UI-only change limited to hover styling on the copy prompt button; no behavior, state, or data handling is modified.

Overview
Updates CopyPromptButton hover styling to match a standard link pattern by replacing the background/border color hover effect with an underline (textDecoration) and adjusting the CSS transition accordingly.

Reviewed by Cursor Bugbot for commit 41d71e8. Bugbot is set up for automated code reviews on this repo. Configure here.

@mintlify
Copy link
Copy Markdown
Contributor

mintlify bot commented Apr 15, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Kernel 🟢 Ready View Preview Apr 15, 2026, 7:40 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@masnwilliams masnwilliams marked this pull request as ready for review April 15, 2026 19:42
@firetiger-agent
Copy link
Copy Markdown

Firetiger deploy monitoring skipped

This PR didn't match the auto-monitor filter configured on your GitHub connection:

Any PR that changes the kernel API. Monitor changes to API endpoints (packages/api/cmd/api/) and Temporal workflows (packages/api/lib/temporal) in the kernel repo

Reason: PR only modifies UI styling for a copy prompt button hover effect, not kernel API endpoints or Temporal workflows.

To monitor this PR anyway, reply with @firetiger monitor this.

cursor: 'pointer',
transition: 'background-color 0.15s ease, border-color 0.15s ease',
textDecoration: 'none',
transition: 'text-decoration 0.15s ease',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transition on non-animatable text-decoration-line is ineffective

Low Severity

The transition: 'text-decoration 0.15s ease' declaration is dead code. CSS cannot transition text-decoration-line (which is what changes between none and underline). Only text-decoration-color and text-decoration-thickness are animatable sub-properties. The underline will still appear and disappear on hover, but it snaps instantly with no smooth transition, making this line misleading.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f5e30a8. Configure here.

cursor[bot]
cursor bot previously approved these changes Apr 15, 2026
@cursor cursor bot dismissed their stale review April 15, 2026 19:48

Risk assessment update after new commits: Low risk (increased from previous Very Low), so I’m dismissing the earlier approval.

What changed in the latest diff:

  • snippets/copy-prompt-button.jsx: adds useLayoutEffect and direct DOM manipulation to hide a placeholder element after hydration, plus hover style behavior updates.
  • index.mdx: adds a static placeholder button-like element in page markup.
  • style.css: adds new global placeholder styling.

Why risk increased:

  • The change is no longer only a narrowly scoped hover-style tweak; it now introduces runtime behavior tied to hydration timing and direct DOM querying.
  • It remains limited to docs UI and does not touch backend, auth, infra, or shared service logic, so overall risk is still Low, not medium/high.

Decision:

  • Approval dismissed due to increased risk after synchronize.
  • Current classification: Low risk.
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6e3f46a. Configure here.

Comment thread style.css Outdated
cursor: pointer;
font-family: inherit;
box-sizing: border-box;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder width doesn't match button's actual rendered width

Medium Severity

The new .copy-prompt-placeholder has max-width: 352px, but the actual <button> rendered by CopyPromptButton has its max-width overridden to 100% by the existing .tinker-box-content button { max-width: 100% !important; } rule. On any screen where the content area is wider than 352px, the placeholder renders at 352px while the hydrated button stretches to fill the container — causing a visible layout shift, which is exactly what the placeholder was designed to prevent.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6e3f46a. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk assessment: Very Low.

I reviewed the actual diff for this update. The PR changes a single UI snippet (snippets/copy-prompt-button.jsx) and only adjusts hover styling behavior for the copy button (switching from background/border hover styling to underline text decoration). There are no logic-flow changes, no data/auth/permission impact, no infrastructure changes, and no shared backend surface affected.

Given the small, isolated frontend presentation-only scope and low blast radius, this is safe to approve.

Open in Web View Automation 

Sent by Cursor Automation: Assign PR reviewers

@masnwilliams masnwilliams merged commit a23f6e8 into main Apr 15, 2026
4 checks passed
@masnwilliams masnwilliams deleted the hypeship/underline-hover-button branch April 15, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant