Skip to content

fix(app-server): preserve detached review context#571

Open
cbusillo wants to merge 3 commits intojust-every:mainfrom
cbusillo:fix/app-server-detached-review-context
Open

fix(app-server): preserve detached review context#571
cbusillo wants to merge 3 commits intojust-every:mainfrom
cbusillo:fix/app-server-detached-review-context

Conversation

@cbusillo
Copy link
Copy Markdown

@cbusillo cbusillo commented Apr 3, 2026

Summary

  • preserve the source thread config when starting detached review/start runs
  • normalize thread aliases before metadata lookup so detached review resolution uses the correct catalog entry

Dependency

Testing

  • cargo test -p code-app-server --quiet
  • ./build-fast.sh
  • manual JSON-RPC probe through the PATH-linked /opt/homebrew/bin/code binary covering model/list, inline review/start, and detached review/start

Finish the thread/resume compatibility shim and add native model/list and review/start handlers to the local app-server compatibility layer.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 355543a0ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cbusillo cbusillo force-pushed the fix/app-server-detached-review-context branch from 355543a to b9331a4 Compare April 3, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant