Complete Playwright visual source: add optional dependency and documentation#24
Open
Complete Playwright visual source: add optional dependency and documentation#24
Conversation
- Add 'playwright' optional dependency group in pyproject.toml - Add Playwright browser capture to Features section in README - Add Playwright to system dependencies with install instructions - Fix missing blank line before VHS safety section in README The Playwright visual source feature (type: playwright) is fully implemented: - PlaywrightRunner class for browser capture via external scripts - CLI: docgen playwright --script ... --url ... --source ... - Compose integration dispatches type: playwright segments - Configuration: playwright section in docgen.yaml - Full test coverage Closes #16 Co-authored-by: John Menke <jmjava@gmail.com>
24c149f to
a34ecfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #16 requested adding
type: playwrightas a visual source for browser-based capture. The implementation is already complete across the codebase. This PR closes the remaining gaps: an explicit optional dependency and complete documentation.What was already implemented
PlaywrightRunnerclass inplaywright_runner.py- runs external capture scriptsdocgen playwrightCLI command for standalone capturetype: playwrightdispatch incompose.pyfor pipeline integrationplaywright:) indocgen.yamlschematype: playwrightvisual map entries and script contracttest_playwright_runner.pyandtest_compose.pyWhat this PR adds
playwrightoptional dependency inpyproject.toml(pip install docgen[playwright])Acceptance criteria from issue #16
docgen playwright --script my_script.py --url http://localhost:3300produces an MP4type: playwrightsegments compose correctly with narration audioCloses #16