Open
Conversation
ashfaq1934
commented
Jan 1, 2023
- Adds a button to each request card and detail page which allows you to delete individual request without having to click clear db.
- Resolves Allow to delete some requests #632
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 86.42% 86.88% +0.45%
==========================================
Files 52 52
Lines 2078 2189 +111
==========================================
+ Hits 1796 1902 +106
- Misses 282 287 +5
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dd3d71e to
b10d04a
Compare
b10d04a to
e919cdd
Compare
gopar
reviewed
Oct 6, 2023
gopar
reviewed
Nov 2, 2023
|
|
||
| def test_delete(self): | ||
| response = self.client.post(reverse('silk:request_detail', kwargs={'request_id': str(self.request.id)})) | ||
| self.assertEqual(response.status_code, HTTPStatus.FOUND) |
There was a problem hiding this comment.
Thanks for the tests! A few nitpicks:
- Can you make sure that this re-routes to the summary page and the object is deleted. (Bonus for test that checks the redirection for header Referer)
- Another test that checks when we pass in a non-existing request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.