bigger decimal fields (20 digits) (hold more currencies)#153
Open
devkral wants to merge 2 commits intojazzband:mainfrom
Open
bigger decimal fields (20 digits) (hold more currencies)#153devkral wants to merge 2 commits intojazzband:mainfrom
devkral wants to merge 2 commits intojazzband:mainfrom
Conversation
… map btc and cheaper currencies (12 places)
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 79.13% 79.15% +0.01%
==========================================
Files 27 27
Lines 1649 1650 +1
Branches 190 190
==========================================
+ Hits 1305 1306 +1
Misses 245 245
Partials 99 99
Continue to review full report at Codecov.
|
devkral
changed the title
Contributor
Author
|
I am not sure if this pull request is a good idea. Most people just want two decimal_places and 12 digits. |
Contributor
Author
|
anyway it is very domain specific (if you want to trade bitcoins or not) |
Contributor
|
I think this should be set by a variable as in #188 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8 decimal places to hold smallest btc unit
12 digits to hold cheaper currencies
#9