Skip to content

fix display of branch names with special characters#956

Open
isc-pbarton wants to merge 2 commits intomainfrom
fix-branch-names
Open

fix display of branch names with special characters#956
isc-pbarton wants to merge 2 commits intomainfrom
fix-branch-names

Conversation

@isc-pbarton
Copy link
Copy Markdown
Collaborator

Fixes #914

@isc-pbarton
Copy link
Copy Markdown
Collaborator Author

CI failing I think because of changes in the intersystemsdc/iris-community:latest image. Fails to install TestCoverage. When I run locally on the same base image I get an error that no IPM registries are configured.

@isc-dchui
Copy link
Copy Markdown
Collaborator

Hm I'm not fully convinced we should necessarily support the "#" character (or spaces) in branch names. I feel like as long as we support this we're fine.

@isc-pbarton
Copy link
Copy Markdown
Collaborator Author

After discussion with @isc-dchui, we decided that just supporting pound sign is kind of arbitrary, but we want to keep the web UI simple rather than supporting everything. Plan is:

  • support smaller set of branch names matching this default set
  • add branch name validation when you create a new branch, both in web UI and source control menus
  • exclude unsupported branch names from web UI, and show warning message if more branches exist with unsupported names. this keeps us reasonably compatible with other git clients

@isc-pbarton isc-pbarton marked this pull request as draft April 15, 2026 14:00
@isc-pbarton isc-pbarton marked this pull request as ready for review April 16, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Branch not displaying in GitUI

2 participants