fix display of branch names with special characters#956
Open
isc-pbarton wants to merge 2 commits intomainfrom
Open
fix display of branch names with special characters#956isc-pbarton wants to merge 2 commits intomainfrom
isc-pbarton wants to merge 2 commits intomainfrom
Conversation
Collaborator
Author
|
CI failing I think because of changes in the intersystemsdc/iris-community:latest image. Fails to install TestCoverage. When I run locally on the same base image I get an error that no IPM registries are configured. |
Collaborator
|
Hm I'm not fully convinced we should necessarily support the "#" character (or spaces) in branch names. I feel like as long as we support this we're fine. |
Collaborator
Author
|
After discussion with @isc-dchui, we decided that just supporting pound sign is kind of arbitrary, but we want to keep the web UI simple rather than supporting everything. Plan is:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #914