Skip to content

chore: update cdxgen#533

Merged
KLongmuirHD merged 4 commits intomainfrom
chore/npm_audit_fix_updates
Apr 14, 2026
Merged

chore: update cdxgen#533
KLongmuirHD merged 4 commits intomainfrom
chore/npm_audit_fix_updates

Conversation

@KLongmuirHD
Copy link
Copy Markdown
Contributor

@KLongmuirHD KLongmuirHD commented Apr 14, 2026

  • address npm audit issues with npm audit fix scoped down the PR to just one dependency
  • update cdxgen to latest
  • cdxgen upstream change, changed the type signature of the postProcess function from returning any to Object. Change is made to cast back to any. CI tests will catch regressions.

@KLongmuirHD KLongmuirHD requested a review from a team as a code owner April 14, 2026 00:44
@marco-ippolito
Copy link
Copy Markdown
Member

I don't think this is a good idea, dependency update should be handled by dependabot (and similar).
Running audit fix and pushing the updated lock file creates a hidden discrepancy:
Audit fix can upgrade/downgrade a package in the package lock, but when someone runs npm i gets a different version. It also means by downgrading you might get bugs that were later fixed.
It also might break some packages the dependency tree that expected a certain feature/fix from a dependency.
The fact that some dependencies have an advisory is not inherently bad or mean our application is vulnerable.
Audit fix causes more hard than good because it blindly tries to migrate a package to the closest version without an advisory which is dangerous.

@KLongmuirHD KLongmuirHD force-pushed the chore/npm_audit_fix_updates branch from 2ab9ee3 to 3e4370f Compare April 14, 2026 15:14
@KLongmuirHD
Copy link
Copy Markdown
Contributor Author

@marco-ippolito thanks for the feedback. I scoped down the changes to just an explicit bump of cdxgen, and that's it. I'll let dependabot pick up the rest.

@KLongmuirHD KLongmuirHD changed the title chore: npm audit fixes chore: update cdxgen Apr 14, 2026
@KLongmuirHD KLongmuirHD merged commit 08b3ebb into main Apr 14, 2026
12 checks passed
@KLongmuirHD KLongmuirHD deleted the chore/npm_audit_fix_updates branch April 14, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants