You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
address npm audit issues with npm audit fix scoped down the PR to just one dependency
update cdxgen to latest
cdxgen upstream change, changed the type signature of the postProcess function from returning any to Object. Change is made to cast back to any. CI tests will catch regressions.
I don't think this is a good idea, dependency update should be handled by dependabot (and similar).
Running audit fix and pushing the updated lock file creates a hidden discrepancy:
Audit fix can upgrade/downgrade a package in the package lock, but when someone runs npm i gets a different version. It also means by downgrading you might get bugs that were later fixed.
It also might break some packages the dependency tree that expected a certain feature/fix from a dependency.
The fact that some dependencies have an advisory is not inherently bad or mean our application is vulnerable.
Audit fix causes more hard than good because it blindly tries to migrate a package to the closest version without an advisory which is dangerous.
@marco-ippolito thanks for the feedback. I scoped down the changes to just an explicit bump of cdxgen, and that's it. I'll let dependabot pick up the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addressscoped down the PR to just one dependencynpm auditissues withnpm audit fixpostProcessfunction from returninganytoObject. Change is made to cast back toany. CI tests will catch regressions.