Skip to content

Two fixes to Community / Logos page#2148

Merged
dscho merged 2 commits intogit:gh-pagesfrom
mina86:b
Apr 17, 2026
Merged

Two fixes to Community / Logos page#2148
dscho merged 2 commits intogit:gh-pagesfrom
mina86:b

Conversation

@mina86
Copy link
Copy Markdown
Contributor

@mina86 mina86 commented Mar 17, 2026

Firstly, remove bogus comma inside the <img> tags. I believe this was
a left over from when the images were inserted via a function, such as:

image_tag('logos/logomark-orange@2x.png', {:width => 100, :height => 100})

becoming

<img src="/images/logos/logomark-orange@2x.png" width="100", height="100">

Secondly, remove links with an empty href. Those only serve to confuse the
user.

mina86 added 2 commits March 17, 2026 22:37
Eliminate links with empty href attribute.  They serve no useful purpose
since they point back to the same page only confusing the user.
Download links for the images are listed under each image.
Comment thread content/community/logos.html Outdated
<ul class="content-list">
<li>
<a href=""><img src="{{< relurl "images/logos/2color-lightbg@2x.png" >}}" width="294", height="100"></a>
<a href=""><img src="{{< relurl "images/logos/2color-lightbg@2x.png" >}}" width="294" height="100"></a>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're absolutely correct, both the comma and the empty href were mistakes in 6445fad that were missed during review of that massive PR.

@dscho dscho merged commit 954ea90 into git:gh-pages Apr 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants