Skip to content

test(langchain): Separate test to remove conditional#6076

Open
alexander-alderman-webb wants to merge 2 commits intowebb/langchain/tool-pipeline-namefrom
webb/langchain/split-out-test
Open

test(langchain): Separate test to remove conditional#6076
alexander-alderman-webb wants to merge 2 commits intowebb/langchain/tool-pipeline-namefrom
webb/langchain/split-out-test

Conversation

@alexander-alderman-webb
Copy link
Copy Markdown
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Apr 15, 2026

Description

Dedicate test_langchain_openai_tools_agent_no_prompts() to all configuration combinations that omit sensitive data, and keep test_langchain_openai_tools_agent() focused on the sensitive data path.

Issues

Reminders

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Langchain

  • Record run_name in on_chat_model_start by alexander-alderman-webb in #5924
  • Record run_name in on_tool_start by alexander-alderman-webb in #5925

Other

  • (ci) Cancel in-progress PR workflows on new commit push by joshuarli in #5994

Bug Fixes 🐛

  • (langchain) Set agent name as gen_ai.agent.name for chat and tool spans by alexander-alderman-webb in #5877

Internal Changes 🔧

  • (langchain) Separate test to remove conditional by alexander-alderman-webb in #6076

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Codecov Results 📊

142 passed | Total: 142 | Pass Rate: 100% | Execution Time: 23.84s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +116
Passed Tests 📈 +116
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 14086 uncovered lines.
✅ Project coverage is 33.74%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    27.64%    33.74%     +6.1%
==========================================
  Files          190       191        +1
  Lines        21358     21259       -99
  Branches      7066      7008       -58
==========================================
+ Hits          5903      7173     +1270
- Misses       15455     14086     -1369
- Partials       561       700      +139

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review April 15, 2026 07:42
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner April 15, 2026 07:43
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1e622db. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants