Skip to content

fix(grpc): add isolation_scope to async server interceptor#5940

Open
robinvd wants to merge 2 commits intogetsentry:masterfrom
robinvd:master
Open

fix(grpc): add isolation_scope to async server interceptor#5940
robinvd wants to merge 2 commits intogetsentry:masterfrom
robinvd:master

Conversation

@robinvd
Copy link
Copy Markdown

@robinvd robinvd commented Apr 2, 2026

Description

Fixes #5894

The async gRPC server interceptor was missing isolation_scope() wrapping, causing scope state to leak between concurrent requests. The sync interceptor already had this. This PR adds the missing isolation scope to the async unary_unary handler and adds a test proving request isolation.

Issues

Reminders

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (ci) Cancel in-progress PR workflows on new commit push by joshuarli in #5994

Bug Fixes 🐛

  • (grpc) Add isolation_scope to async server interceptor by robinvd in #5940

Internal Changes 🔧

  • Set explicit base-branch for codecov action by ericapisani in #5992

🤖 This preview updates automatically when you update the PR.

@robinvd robinvd marked this pull request as ready for review April 3, 2026 07:20
@robinvd robinvd requested a review from a team as a code owner April 3, 2026 07:20
@ericapisani
Copy link
Copy Markdown
Member

Thanks for opening this PR @robinvd !

This PR adds the missing isolation scope to the async unary_unary handler and adds a test proving request isolation.

I'm not seeing the test mentioned in your description in this change set - was it potentially missed in the commit that was made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gRPC aio ServerInterceptor missing isolation_scope per request

2 participants