Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Ahhh this is great, thank you for being thorough in documenting this 🙏 |
|
|
||
| Adding a new reason involves multiple repos in Sentry but is very straight-forward: | ||
|
|
||
| 1. Register the new reason in [snuba](https://github.com/getsentry/snuba/blob/master/rust_snuba/src/processors/outcomes.rs#L15). The list MUST be ordered alphabetically ([Example PR](https://github.com/getsentry/snuba/pull/7866)). |
There was a problem hiding this comment.
We probably want this to point to a specific commit, otherwise it will drift over time; alternatively, just the commits/PRs are sufficient to document how it's done.
| Adding a new reason involves multiple repos in Sentry but is very straight-forward: | ||
|
|
||
| 1. Register the new reason in [snuba](https://github.com/getsentry/snuba/blob/dd7ca91d81484455953653f59ed4ab90ecbc9719/rust_snuba/src/processors/outcomes.rs#L15). The list MUST be ordered alphabetically ([Example PR](https://github.com/getsentry/snuba/pull/7866)). | ||
| 2. Add the new reason to the Sentry frontend to show it in the Usage Stats and `_admin` pages ([Example PR](https://github.com/getsentry/sentry/pull/112937)). |
There was a problem hiding this comment.
There is a difference between _admin and stats page, as in we group certain outcomes for user consumption and do not just return the raw outcome like we do on _admin.
There was a problem hiding this comment.
I checked with @shellmayr and Cursor: While true that we group and omit certain outcomes/discard reason sub categories in the user-facing page, this currently only concerns server-side outcomes. Client outcomes are all displayed at the moment. I'm gonna merge this as-is for the time being because I don't (yet) see a reason to not emit an outcome. Happy to follow up with changes if we need any.
4 participants
Since adding a new client outcomes reason involves quite a few steps, this PR adds a short instruction section to develop docs. We can probably build a skill from this or point clankers to these docs.
I purposefully didn't bump the changelog version since this doesn't change any spec. It just adds information.
h/t @shellmayr for calling out the missing pieces!
(ref https://linear.app/getsentry/issue/SDK-1123/add-client-report-outcome-for-dropped-spans-because-of-missing-parent)