feat(init): pre-supply existingSentry to eliminate roundtrip#755
Open
feat(init): pre-supply existingSentry to eliminate roundtrip#755
Conversation
Pre-compute sentry detection alongside dirListing before the workflow starts and pass the result in inputData. The server-side check-existing-sentry step can now skip the suspend/resume cycle when this data is present, saving one full roundtrip (HTTP + D1 read/write on Cloudflare Workers). Companion to getsentry/cli-init-api#92. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 45c6b79. Configure here.
Drop async from detectSentry wrapper (lint: no-await-in-async) and apply biome formatting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
If detection throws (e.g. permission error), fall back to null so the workflow uses the suspend/resume path instead of crashing the wizard with a misleading "Connection failed" message. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detectDsn) alongsidedirListingbefore the workflow startsexistingSentryininputData, allowing the server-sidecheck-existing-sentrystep to skip its suspend/resume cycleTest plan
sentry init --dry-runon a project with existing Sentry setup — verify detection still workssentry init --dry-runon a clean project — verifyexistingSentryis{ status: "none", signals: [] }🤖 Generated with Claude Code