Conversation
|
Here the document suggests
But the code actually doesn't allow the balance to fall below the sum of |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1733 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 139 139
Lines 27693 27695 +2
=======================================
+ Hits 25069 25071 +2
Misses 2624 2624
🚀 New features to boost your workflow:
|
|
While validating power state validate_power_state here we are missing upper bound check on the Let me know if this is a real concern i can create a separate issue or change it in this PR. |
|
in amout_vested
could give us the |
|
AddPairKey encoding is not implemented, we are not using it anywhere but still it panics. |
While taking the code from the builtin actor into the
fil-actor-statefor the V18 actor update, coderabbit AI suggested some fixes/comments here.I have fixed couple of them rest were about adding the checks for negative and zero but I verified most of them didn't find anything worth changing but will post in the comments if anybody thinks they are worth it. Also It turns out the changes were not that big.