[eslint-plugin-react-hooks] Track useEffectEvent in FunctionExpression#36260
Open
imjordanxd wants to merge 1 commit intofacebook:mainfrom
Open
[eslint-plugin-react-hooks] Track useEffectEvent in FunctionExpression#36260imjordanxd wants to merge 1 commit intofacebook:mainfrom
useEffectEvent in FunctionExpression#36260imjordanxd wants to merge 1 commit intofacebook:mainfrom
Conversation
…n components
The RulesOfHooks ESLint rule tracked useEffectEvent definitions in
FunctionDeclaration, ArrowFunctionExpression, ComponentDeclaration, and
HookDeclaration nodes but missed FunctionExpression. This meant
useEffectEvent references inside `const Foo = function() { ... }` style
components were not validated.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
imjordanxd
changed the title
useEffectEvent in FunctionExpression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While analyzing
RulesOfHooks.ts, noticed thatuseEffectEventtracking was handled inFunctionDeclaration,ArrowFunctionExpression,ComponentDeclaration, andHookDeclarationvisitors but was missingFunctionExpression. This meantuseEffectEventreferences insideconst Foo = function() { ... }style components were not validated.ExhaustiveDeps.tsalready handlesFunctionExpression— the gap was only inRulesOfHooks.ts.Test plan
useEffectEventin a function expression component called insideuseEffectuseEffectEventin a function expression component passed down as a prop🤖 Generated with Claude Code