Skip to content

fix: update eslint-scope to v9#285

Open
Pixel998 wants to merge 4 commits intomainfrom
chore/eslint-scope-types
Open

fix: update eslint-scope to v9#285
Pixel998 wants to merge 4 commits intomainfrom
chore/eslint-scope-types

Conversation

@Pixel998
Copy link
Copy Markdown
Contributor

@Pixel998 Pixel998 commented Dec 31, 2025

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This PR upgrades eslint-scope to the latest version and removes the separate @types/eslint-scope dependency now that eslint-scope ships its own TypeScript declarations.

What changes did you make? (Give an overview)

  • Upgraded eslint-scope from ^8.4.0 to ^9.1.2
  • Removed @types/eslint-scope from devDependencies
  • Removed a stale sourceType as never cast.

Related Issues

Is there anything you'd like reviewers to focus on?

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 31, 2025

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit e54fb29
🔍 Latest deploy log https://app.netlify.com/projects/eslint-code-explorer/deploys/69dde00ee7f2df000803e2ae
😎 Deploy Preview https://deploy-preview-285--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslintbot eslintbot added this to Triage Dec 31, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 31, 2025
@github-actions
Copy link
Copy Markdown

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Jan 11, 2026
@Pixel998 Pixel998 self-assigned this Jan 12, 2026
@Pixel998 Pixel998 removed the Stale label Jan 12, 2026
@Pixel998 Pixel998 moved this from Needs Triage to Implementing in Triage Jan 12, 2026
@Pixel998 Pixel998 changed the title chore: remove @types/eslint-scope chore: upgrade eslint-scope to v9 Apr 7, 2026
@Pixel998 Pixel998 marked this pull request as ready for review April 7, 2026 06:25
@DMartens
Copy link
Copy Markdown
Contributor

DMartens commented Apr 9, 2026

The new scope manager requires calling sourceCode.addGlobals to add builtin globals.
For example currently Object is not being resolved to a global.

@Pixel998
Copy link
Copy Markdown
Contributor Author

Pixel998 commented Apr 14, 2026

Do you mean we should call scopeManager.addGlobals() (rather than sourceCode.addGlobals()) to add language globals? If so, that seems like a separate follow-up from the eslint-scope upgrade itself.

@Pixel998 Pixel998 changed the title chore: upgrade eslint-scope to v9 fix: update eslint-scope to v9 Apr 14, 2026
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chore

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

3 participants