Open
Conversation
GreenGremlin
force-pushed
the
host-node-matchers
branch
2 times, most recently
from
e1534fb to
8752813
Compare
Contributor
Author
|
Given that |
GreenGremlin
force-pushed
the
host-node-matchers
branch
2 times, most recently
from
bfc4e33 to
e5beebc
Compare
Member
|
I consider it a bug that |
Contributor
Author
|
Is there anything I can do to help get this merged? |
GreenGremlin
force-pushed
the
host-node-matchers
branch
from
e5beebc to
dbb2de3
Compare
Contributor
Author
|
Closing this PR, due to its age, but it would still be nice to have. |
Member
|
Age shouldn’t be a factor :-) let’s leave this open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-on to #336, until it is merged, this PR will also include changes from that PR.
This change adds three new matchers, similar to the existing
toContainMatchingElementmatchers, except that the new matchers only match against "host nodes". Enzyme v3.1 added ahostNodesmethod that filters a result set to just "host nodes". According to thehostNodesdocumentation, "host nodes" are "are HTML elements rather than custom React components, e.g.<div>versus<MyComponent>."