Skip to content

compiler: Enhance detect_accesses#2886

Open
FabioLuporini wants to merge 1 commit intomainfrom
tma-write
Open

compiler: Enhance detect_accesses#2886
FabioLuporini wants to merge 1 commit intomainfrom
tma-write

Conversation

@FabioLuporini
Copy link
Copy Markdown
Contributor

Test in PRO in the PR/branch with same name as this one

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.45%. Comparing base (bd39274) to head (010ab52).

Files with missing lines Patch % Lines
devito/types/parallel.py 66.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2886      +/-   ##
==========================================
+ Coverage   83.43%   83.45%   +0.01%     
==========================================
  Files         248      248              
  Lines       51381    51404      +23     
  Branches     4431     4431              
==========================================
+ Hits        42871    42900      +29     
+ Misses       7757     7753       -4     
+ Partials      753      751       -2     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.80% <73.07%> (+<0.01%) ⬆️
pytest-gpu-gcc- 78.04% <73.07%> (+<0.01%) ⬆️
pytest-gpu-icx- 77.67% <73.07%> (+0.01%) ⬆️
pytest-gpu-nvc-nvidiaX 69.33% <73.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Search among the Indexeds (Most accesses typically stem from Indexeds)
plain_indexeds = retrieve_indexed(exprs, deep=True)

# Search among higher order objects, which still represent meaningful accesses
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look very specific and seems like that's something retrieve_index should catch

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is that other objects can end up there, in the future, maybe...

as for retrieve_indexed catching it: disagree, it's not an implicit Indexed, it's rarther a logical representation of the base address of the TensorMove -- as an Indexed, for homogeneity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants