Skip to content

perf(worker): Eagerly load repository in test analytics upload query#796

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/ta-optimize-uploads
Open

perf(worker): Eagerly load repository in test analytics upload query#796
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/ta-optimize-uploads

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 14, 2026

Fixes WORKER-Y72. The issue was that: Multiple ReportSession QuerySet evaluations without select_related cause N+1 queries for related report, commit, and repository objects.

  • Added select_related("report__commit__repository") to the get_relevant_uploads query to eagerly load the related repository object, reducing N+1 queries.
  • Converted the result of get_relevant_uploads to a list to ensure immediate evaluation of the queryset.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13270658

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk performance-only change that alters queryset loading/evaluation; main risk is unexpected memory usage or behavior differences from eager evaluation.

Overview
Improves performance of flake processing by eager-loading report/commit/repository on the uploads query via select_related, avoiding N+1 DB queries when iterating uploads.

Also forces immediate evaluation of the uploads queryset (list(...)) in process_flakes_for_commit to prevent repeated queryset evaluation during logging/iteration.

Reviewed by Cursor Bugbot for commit a74529e. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (8c332b1) to head (a74529e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #796   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1306     1306           
  Lines       48004    48004           
  Branches     1636     1636           
=======================================
  Hits        44286    44286           
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.58% <0.00%> (ø)
workerunit 90.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants