perf(worker): Eagerly load repository in test analytics upload query#796
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
perf(worker): Eagerly load repository in test analytics upload query#796sentry[bot] wants to merge 1 commit intomainfrom
sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1306 1306
Lines 48004 48004
Branches 1636 1636
=======================================
Hits 44286 44286
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-Y72. The issue was that: Multiple
ReportSessionQuerySet evaluations withoutselect_relatedcause N+1 queries for relatedreport,commit, andrepositoryobjects.select_related("report__commit__repository")to theget_relevant_uploadsquery to eagerly load the related repository object, reducing N+1 queries.get_relevant_uploadsto a list to ensure immediate evaluation of the queryset.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13270658
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Low Risk
Low risk performance-only change that alters queryset loading/evaluation; main risk is unexpected memory usage or behavior differences from eager evaluation.
Overview
Improves performance of flake processing by eager-loading
report/commit/repositoryon the uploads query viaselect_related, avoiding N+1 DB queries when iterating uploads.Also forces immediate evaluation of the uploads queryset (
list(...)) inprocess_flakes_for_committo prevent repeated queryset evaluation during logging/iteration.Reviewed by Cursor Bugbot for commit a74529e. Bugbot is set up for automated code reviews on this repo. Configure here.