fix: restore initial controlled ComboBox selection#21999
Open
adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
Open
fix: restore initial controlled ComboBox selection#21999adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21999 +/- ##
==========================================
+ Coverage 94.90% 94.93% +0.02%
==========================================
Files 541 541
Lines 45253 45255 +2
Branches 6359 6361 +2
==========================================
+ Hits 42949 42964 +15
+ Misses 2172 2159 -13
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue.
Restored initial controlled
ComboBoxselection.Changelog
Changed
ComboBoxselection.Testing / Reviewing
When the component is initially rendered with a
selectedItemprop, clearing the field or entering an invalid value does not revert to the previously selected value. After making a new selection, the behavior works as expected, suggesting the issue only occurs on initial load.Using
initialSelectedItemproduces the expected behavior, but passing bothinitialSelectedItemandselectedItemisn't appropriate since they represent uncontrolled and controlled usage, respectively.The issue can be reproduced in the Storybook: https://react.carbondesignsystem.com/?path=/docs/components-combobox--overview#selecteditem.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesMore details can be found in the pull request guide