fix(ComposedModal): add alert prop to support alertdialog role#21985
Open
nami8824 wants to merge 1 commit intocarbon-design-system:mainfrom
Open
fix(ComposedModal): add alert prop to support alertdialog role#21985nami8824 wants to merge 1 commit intocarbon-design-system:mainfrom
nami8824 wants to merge 1 commit intocarbon-design-system:mainfrom
Conversation
Add `alert` prop to ComposedModal that sets role="alertdialog" and aria-describedby pointing to the ModalBody. This allows screen readers to announce alert/error/warning modals appropriately. Closes carbon-design-system#21342
Contributor
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
I have read the DCO document and I hereby sign the DCO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
alertprop to ComposedModal that sets role="alertdialog" and aria-describedby pointing to the ModalBody. This allows screen readers to announce alert/error/warning modals appropriately.Closes #21342
Changelog
New
alertprop toComposedModalthat enablesrole="alertdialog"and wiresaria-describedbytoModalBody, matching the behavior of `ModalTesting / Reviewing
ComposedModalwithalertprop andopenproprole="alertdialog"aria-describedbypoints to theModalBodyelement'sidModalBodyhas a customid, confirm that id is usedPR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide