feat: remove customRippleColor from components#4899
Open
adrcotfas wants to merge 1 commit into@adrcotfas/fix/ripplefrom
Open
feat: remove customRippleColor from components#4899adrcotfas wants to merge 1 commit into@adrcotfas/fix/ripplefrom
adrcotfas wants to merge 1 commit into@adrcotfas/fix/ripplefrom
Conversation
|
The mobile version of example app from this branch is ready! You can see it here. |
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PlatformColorfor Dynamic Themes without native modules which does not support applying analphato it, something required for the current implementation of ripple color.PlatformColorand custom ripple color is not compatible.Button,IconButton,SearchBar,Chipetc does not follow the MD3 guidelines.CompositionLocalProviderconfig so custom ripples are not encouraged.0.1alpha applied to a neutral color. Per specs, some components likeButtonneed a0.1alpha applied to a primary/tertiary color. At this opacity it's hard to distinguish the neutral from the primary ripple and we don't have a choice when usingPlatformColoranyway.android_rippleto supportPlatformColorand an alpha that will allow Paper to follow the MD3 ripple specs for all components: feat(Pressable): add support for PlatformColor and alpha facebook/react-native#56395.Order of merging:
Related issue
Test plan
Run the example app and observe the ripple color for components;
Buttonfor example will have a slightly different tint.