Document Connection::afterCommit() and deferred commit events#8281
Open
jamisonbryant wants to merge 2 commits into5.nextfrom
Open
Document Connection::afterCommit() and deferred commit events#8281jamisonbryant wants to merge 2 commits into5.nextfrom
jamisonbryant wants to merge 2 commits into5.nextfrom
Conversation
…eleteCommit behavior
8 tasks
jamisonbryant
added a commit
to cakephp/cakephp
that referenced
this pull request
Apr 14, 2026
Add Connection::afterCommit() to fix suppressed afterSaveCommit/afterDeleteCommit in outer transactions Docs here: cakephp/docs#8281
markstory
approved these changes
Apr 16, 2026
| explicitly set `'strategy' => 'select'` when defining associations. | ||
| See [Associations](../orm/associations#has-many-associations) for more details. | ||
| - `Model.afterSaveCommit` and `Model.afterDeleteCommit` events are now fired | ||
| when `save()` or `delete()` is called inside an outer transaction. Previously, |
Member
There was a problem hiding this comment.
Suggested change
| when `save()` or `delete()` is called inside an outer transaction. Previously, | |
| when `save()` or `delete()` is called within an open transaction. Previously, |
🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation for
Connection::afterCommit()and the updated behavior ofafterSaveCommit/afterDeleteCommitevents introduced in cakephp/cakephp#19383.Major Changes
afterCommitsection todatabase-basics.mddocumentingConnection::afterCommit()with API signature, usage examples (basic and nested transactions), and explanation of immediate-execution semantics outside transactionsafterSaveCommitsection intable-objects.mdto document the new deferred behavior when called inside outer transactions, replacing the previous "not triggered" languageafterDeleteCommitsection intable-objects.mdwith the same deferred behavior documentationChanged in version 5.4.0annotations to both event sectionsMinor Changes
afterDeleteCommitdescription ("has been is committed" -> "has been committed")Work Remaining
None.
Test Plan
database-basics.html#aftercommitrenders correctly with code examples and version annotationtable-objects.html#aftersavecommitshows updated behavior description and version annotationtable-objects.html#afterdeletecommitshows updated behavior description and version annotation