fix: replace broken bridge-token link with Optimism standard bridge docs#1271
Closed
ygd58 wants to merge 2 commits intobase:masterfrom
Closed
fix: replace broken bridge-token link with Optimism standard bridge docs#1271ygd58 wants to merge 2 commits intobase:masterfrom
ygd58 wants to merge 2 commits intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
Author
Author
|
@soheimam Is this PR also not needed? The bridge-token link returns 404 on the live docs site. Happy to close if not required. |
ddf660c to
c2ff389
Compare
c2ff389 to
166f48d
Compare
Author
|
Closing this PR. The page is not live as noted by @soheimam, and the Optimism link I added was incorrect. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The link Bridging an L1 Token to Base in
bridges.mdxpoints to a page that does not exist, causing a 404 error reported in #1159.A redirect exists in
docs.jsonpointing this path to/base-chain/network-information/bridges(the same page), which creates a self-referencing loop.Fix
Replaced the broken internal link with the official Optimism standard bridge documentation at
https://docs.optimism.io/builders/app-developers/bridging/standard-bridge, which covers the exact topic (deploying ERC-20 tokens on Base using standard bridge contracts).Closes #1159