Open
Conversation
atomicptr
reviewed
Apr 16, 2026
| @@ -0,0 +1,41 @@ | |||
| package anima_raylib | |||
Owner
There was a problem hiding this comment.
This should probably be anima_karl2d right? :)
| package anima_raylib | ||
|
|
||
| import ".." | ||
| import k2 "../../../karl2d" |
Owner
There was a problem hiding this comment.
This gives me a bit of head scratching because this forces us to have karl2d beside anima in the file tree but I'm also not sure if there even is a better solution 🤔
A super random idea would be:
import k2 "karl2d:."and then when building you can pick the path yourself using
$ odin run . -collection:karl2d="../../../karl2d"Do you have another idea? I'm not yet sure if this is a good idea, but I'd prefer if we don't have to hardcode the path (even though this seems like a very sensible standard)
Owner
|
Thanks for the pull request, looks very good overall :)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the karl2d library